Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 103993007: Fix runisolatedtest.py to support 1.x .isolated files. (Closed)

Created:
7 years ago by M-A Ruel
Modified:
7 years ago
Reviewers:
iannucci, Nico
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org, ckocagil, csharp, Vadim Sh., Nico
Base URL:
https://chromium.googlesource.com/a/chromium/tools/build.git@master
Visibility:
Public.

Description

Fix runisolatedtest.py to support 1.x .isolated files. Relax the check to accept anything 1.x, since they are guaranteed to be backward compatible. Recent swarming.client changes bumped the version to 1.1 then 1.2 but the file format is guaranteed to be still readable. TBR=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=240325

Patch Set 1 #

Patch Set 2 : riiiietveld #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scripts/slave/runisolatedtest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
The revert was https://codereview.chromium.org/111393006/. It only showed up on the CI because the hack in ...
7 years ago (2013-12-12 14:44:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/103993007/20001
7 years ago (2013-12-12 14:45:03 UTC) #2
commit-bot: I haz the power
Change committed as 240325
7 years ago (2013-12-12 14:46:18 UTC) #3
Nico
7 years ago (2013-12-12 18:09:31 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698