Add PPB_Alarms_Dev interface definition.

ppapi/generators/idl_c_header.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """ Generator for C style prototypes and definitions """
 
 import glob
 import os
 import re
@@ skipping 127 matching lines @@
   if last_group:
     out.Write(CommentLines(['*',' @}', '']) + '\n')
 
 
 def CheckTypedefs(filenode, releases):
   """Checks that typedefs don't specify callbacks that take some structs.
 
   See http://crbug.com/233439 for details.
   """
   cgen = CGen()
-  # TODO(teravest): Fix the following callback to pass PP_Var by pointer
-  # instead of by value.
-  node_whitelist = ['PP_Ext_Alarms_OnAlarm_Func_Dev_0_1']
+  # TODO(yzshen): (1) remove PP_Ext_Alarms_OnAlarm_Func_Dev_0_1 and the
+  # corresponding whitelist entry; (2) fix this check -- it should be okay for
+  # PP_Alarms_OnAlarm_Dev to pass a struct pointer.
+  node_whitelist = ['PP_Ext_Alarms_OnAlarm_Func_Dev_0_1',
+                    'PP_Alarms_OnAlarm_Dev']

[Mark Seaborn, 2013/12/10 15:56:17]

Don't add new entries to this whitelist, please.  Entries here are callbacks
that don't work on PNaCl, as you should find when you add tests for this
interface and enable them under PNaCl.

When this list was added in April (in
https://codereview.chromium.org/13973011/), the intention was that
PP_Ext_Alarms_OnAlarm_Func_Dev_0_1 would get fixed, not that it is an acceptable
use of call-by-value.

[yzshen1, 2013/12/10 18:06:56]

I have just removed PP_Ext_Alarms_OnAlarm_Func_Dev_0_1 yesterday. Sorry I didn't
do it earlier because we held off the development of this project for a while
and that interface was never implemented.

Please note that the new entry I added (PP_Alarms_OnAlarm_Dev) passes struct by
reference. I think that is allowed, right? This check is problematic to issue an
error.

 
On 2013/12/10 15:56:17, Mark Seaborn wrote:

[yzshen1, 2013/12/10 18:08:24]

A little bit clarification, when I said "pass by reference", I meant "pass by
pointer". :)

   for node in filenode.GetListOf('Typedef'):
     if node.GetName() in node_whitelist:
       continue
     build_list = node.GetUniqueReleases(releases)
     callnode = node.GetOneOf('Callspec')
     if callnode:
       for param in callnode.GetListOf('Param'):
         if param.GetListOf('Array'):
           continue
         if cgen.GetParamMode(param) != 'in':
@@ skipping 185 matching lines @@
     print "Golden file for M13-M15 failed."
     failed =1
   else:
     print "Golden file for M13-M15 passed."
 
   return failed
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))