Issue 10399100: Move FileDescriptorShuffle to base/posix. This file is very posix-specific.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10399100: Move FileDescriptorShuffle to base/posix. This file is very posix-specific. (Closed)

Created:
8 years, 7 months ago by brettw

Modified:
8 years, 1 month ago

Reviewers:
Nico

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Move FileDescriptorShuffle to base/posix. This file is very posix-specific. TEST=it compiles BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166970

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -480 lines)			Patch
M	base/base.gyp	View	1	4 chunks	+3 lines, -3 lines	0 comments	Download
M	base/base.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	base/file_descriptor_shuffle.h	View	1	1 chunk	+0 lines, -87 lines	0 comments	Download
D	base/file_descriptor_shuffle.cc	View		1 chunk	+0 lines, -96 lines	0 comments	Download
D	base/file_descriptor_shuffle_unittest.cc	View	1	1 chunk	+0 lines, -287 lines	0 comments	Download
A +	base/posix/file_descriptor_shuffle.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	base/posix/file_descriptor_shuffle.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	base/posix/file_descriptor_shuffle_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	base/process_util.h	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Nico

lgtm (since it's just a move, but I'm neither in base/OWNERS or wrote this code, ...

8 years, 1 month ago (2012-11-08 21:52:00 UTC) #2

brettw

8 years, 1 month ago (2012-11-08 22:05:22 UTC) #3

You seemed like a good posix person and I felt guilty asking agl.