Issue 10399069: Reland 137540 - Disable off-store extension installs by default. Also get rid of ExtensionService::…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10399069: Reland 137540 - Disable off-store extension installs by default. Also get rid of ExtensionService::… (Closed)

Created:
8 years, 7 months ago by Aaron Boodman

Modified:
8 years, 7 months ago

Reviewers:

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, rdsmith+dwatch_chromium.org, Nirnimesh, Aaron Boodman, anantha, dyu1, dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland 137540 - Disable off-store extension installs by default. Also get rid of ExtensionService::IsDownloadFromGallery." This removes a pyauto test that was failing. The test needs to be different depending on whether a feature is on or off, but there's currently no good way to test whether a feature is enabled from pyauto. BUG=55584 TBR=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137699

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+135 lines, -188 lines)			Patch
M	chrome/browser/download/chrome_download_manager_delegate.cc	View	4 chunks	+33 lines, -25 lines	0 comments	Download
M	chrome/browser/download/download_browsertest.cc	View	5 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/download/download_crx_util.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/download/download_crx_util.cc	View	2 chunks	+2 lines, -11 lines	0 comments	Download
M	chrome/browser/download/download_shelf_context_menu.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/bundle_installer.cc	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.cc	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer_browsertest.cc	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	2 chunks	+0 lines, -66 lines	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_api.cc	View	2 chunks	+4 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/webstore_inline_installer.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/webstore_installer.h	View	2 chunks	+19 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/webstore_installer.cc	View	3 chunks	+23 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/common/extensions/extension_switch_utils.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/functional/downloads.py	View	1 chunk	+0 lines, -16 lines	0 comments	Download