Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: Source/modules/accessibility/AXNodeObject.h

Issue 1039873002: AX presentation role should be inherited to its required owned elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Moved code to AXNodeObject Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXNodeObject.h
diff --git a/Source/modules/accessibility/AXNodeObject.h b/Source/modules/accessibility/AXNodeObject.h
index 759b4045ebd64aa0733be5bee0e3f3c1261c9366..4d556348b484a9360a0659de5063a66978c9052b 100644
--- a/Source/modules/accessibility/AXNodeObject.h
+++ b/Source/modules/accessibility/AXNodeObject.h
@@ -57,6 +57,7 @@ protected:
#endif
virtual bool computeAccessibilityIsIgnored() const override;
+ virtual bool computeHasInheritedPresentationRole() const override;
virtual AccessibilityRole determineAccessibilityRole();
AccessibilityRole determineAccessibilityRoleUtil();
String accessibilityDescriptionForElements(WillBeHeapVector<RawPtrWillBeMember<Element>> &elements) const;
@@ -194,6 +195,8 @@ protected:
virtual void textChanged() override;
virtual void updateAccessibilityRole() override final;
+ bool isPresentationRole(const AXObject*) const;
+
private:
Node* m_node;
@@ -201,6 +204,9 @@ private:
void alternativeText(Vector<AccessibilityText>&) const;
void ariaLabeledByText(Vector<AccessibilityText>&) const;
void changeValueByPercent(float percentChange);
+ bool isListElement(Node*) const;
+ bool isPresentationRoleInTable(AXObject*) const;
+ bool isRequiredOwnedElement(AXObject*) const;
float stepValueForRange() const;
AXObject* findChildWithTagName(const HTMLQualifiedName&) const;
};

Powered by Google App Engine
This is Rietveld 408576698