Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: Source/modules/accessibility/AXLayoutObject.h

Issue 1039873002: AX presentation role should be inherited to its required owned elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXLayoutObject.h
diff --git a/Source/modules/accessibility/AXLayoutObject.h b/Source/modules/accessibility/AXLayoutObject.h
index 647d2c992c6e5641d96dd94af348d56018d96f0a..a3a8c0fcc046b1958ce8b9d96b77220f11380b85 100644
--- a/Source/modules/accessibility/AXLayoutObject.h
+++ b/Source/modules/accessibility/AXLayoutObject.h
@@ -72,6 +72,7 @@ protected:
mutable LayoutRect m_cachedFrameRect;
mutable IntPoint m_cachedScrollPosition;
mutable bool m_cachedElementRectDirty;
+ mutable bool m_hasInheritedPresentationRole;
//
// Overridden from AXObject.
@@ -192,6 +193,10 @@ protected:
virtual VisiblePosition visiblePositionForIndex(int) const override;
virtual void lineBreaks(Vector<int>&) const override;
+ virtual bool hasInheritedPresentationRole() const override { return m_hasInheritedPresentationRole; }
+ bool isPresentationRole(AXObject*) const;
dmazzoni 2015/03/29 07:46:22 Implement this in AXNodeObject instead of AXLayout
je_julie(Not used) 2015/03/31 16:14:27 Thanks for suggestion. I move it at AXNodeObject.
+ bool isPresentationRoleInTable(AXObject*) const;
+
private:
bool isAllowedChildOfTree() const;
void ariaListboxSelectedChildren(AccessibilityChildrenVector&);
@@ -202,6 +207,8 @@ private:
bool layoutObjectIsObservable(LayoutObject*) const;
LayoutObject* layoutParentObject() const;
bool isDescendantOfElementType(const HTMLQualifiedName& tagName) const;
+ bool isListElement(Node*) const;
+ bool isRequiredOwnedElement(AXObject*) const;
bool isSVGImage() const;
void detachRemoteSVGRoot();
AXSVGRoot* remoteSVGRootElement() const;

Powered by Google App Engine
This is Rietveld 408576698