Source/modules/accessibility/AXListBoxOption.h - Issue 1039873002: AX presentation role should be inherited to its required owned elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/accessibility/AXListBoxOption.h

Issue 1039873002: AX presentation role should be inherited to its required owned elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/modules/accessibility/AXLayoutObject.cpp ('k') | Source/modules/accessibility/AXListBoxOption.cpp » ('j') | Source/modules/accessibility/AXListBoxOption.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2008 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57 virtual String title(TextUnderElementMode) const override { return String(); }	57 virtual String title(TextUnderElementMode) const override { return String(); }

58	58

59 private:	59 private:

60 virtual bool isListBoxOption() const override { return true; }	60 virtual bool isListBoxOption() const override { return true; }

61 virtual bool canHaveChildren() const override { return false; }	61 virtual bool canHaveChildren() const override { return false; }

62 virtual bool computeAccessibilityIsIgnored() const override;	62 virtual bool computeAccessibilityIsIgnored() const override;

63	63

64 HTMLSelectElement* listBoxOptionParentNode() const;	64 HTMLSelectElement* listBoxOptionParentNode() const;

65 int listBoxOptionIndex() const;	65 int listBoxOptionIndex() const;

66 AXObject* listBoxOptionAXObject(HTMLElement*) const;	66 AXObject* listBoxOptionAXObject(HTMLElement*) const;

	67 bool isParentPresentationRole() const;
	dmazzoni 2015/04/02 06:22:18 How about isParentPresentational() (since "presen How about isParentPresentational() (since "presentational" is how we're describing role="presentation" OR role="none") je_julie(Not used) 2015/04/02 13:38:08 Done. Show quoted text On 2015/04/02 06:22:18, dmazzoni wrote: > How about isParentPresentational() > > (since "presentational" is how we're describing role="presentation" OR > role="none") Done.
67 };	68 };

68	69

69 DEFINE_AX_OBJECT_TYPE_CASTS(AXListBoxOption, isListBoxOption());	70 DEFINE_AX_OBJECT_TYPE_CASTS(AXListBoxOption, isListBoxOption());

70	71

71 } // namespace blink	72 } // namespace blink

72	73

73 #endif // AXListBoxOption_h	74 #endif // AXListBoxOption_h

OLD	NEW