Issue 1039853002: Added isError method to remoting.Xhr.Error to check for HTTP errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1039853002: Added isError method to remoting.Xhr.Error to check for HTTP errors. (Closed)

Created:
5 years, 9 months ago by John Williams

Modified:
5 years, 9 months ago

Reviewers:
Jamie

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Added isError method to remoting.Xhr.Error to check for HTTP errors. BUG= Committed: https://crrev.com/f6af169dd63e9aa32ec961fe67d6c6c7d7295e38 Cr-Commit-Position: refs/heads/master@{#322694}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -1 line)			Patch
	M	remoting/webapp/crd/js/xhr.js	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	remoting/webapp/crd/js/xhr_unittest.js	View		3 chunks	+41 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039853002/1

5 years, 9 months ago (2015-03-28 01:03:38 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-28 01:47:57 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f6af169dd63e9aa32ec961fe67d6c6c7d7295e38
Cr-Commit-Position: refs/heads/master@{#322694}