[Password Manager] Unify action and origin detection

chrome/browser/password_manager/password_manager_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_samples.h"
 #include "base/metrics/statistics_recorder.h"
 #include "base/path_service.h"
@@ skipping 1827 matching lines @@
   NavigateToFile("/password/login_signup_form.html");
 
   // Let the user interact with the page, so that DOM gets modification events,
   // needed for autofilling fields.
   content::SimulateMouseClickAt(
       WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
 
   // Wait until that interaction causes the password value to be revealed.
   WaitForElementValue("password", "mypassword");
 }
+
+// Check that we can fill in cases where <base href> is set and the action of
+// the form is empty. Regression test for https://crbug.com/360230.

[engedy, 2015/04/01 19:06:24]

We should mention the form not having an action attribute here -- having an
empty action worked before just fine.

[Garrett Casto, 2015/04/01 23:59:29]

Yeah, that wording is confusing. I meant the same thing, but empty is ambiguous.
Changed.

+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest, BaseTagWithEmptyActionTest) {
+  password_manager::TestPasswordStore* password_store =
+      static_cast<password_manager::TestPasswordStore*>(
+          PasswordStoreFactory::GetForProfile(
+              browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS).get());
+
+  EXPECT_TRUE(password_store->IsEmpty());
+
+  NavigateToFile("/password/password_xhr_submit.html");
+
+  NavigationObserver observer(WebContents());
+  scoped_ptr<PromptObserver> prompt_observer(
+      PromptObserver::Create(WebContents()));
+  std::string submit =
+      "document.getElementById('username_field').value = 'myusername';"
+      "document.getElementById('password_field').value = 'mypassword';"
+      "document.getElementById('submit_button').click();";
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), submit));
+  observer.Wait();
+
+  prompt_observer->Accept();
+
+  // Spin the message loop to make sure the password store had a chance to save
+  // the password.
+  base::RunLoop run_loop;

[engedy, 2015/04/01 19:06:24]

nit: Although the current solution is consistent with the rest of the file, you
could just write:

base::RunLoop().RunUntilIdle();

[Garrett Casto, 2015/04/01 23:59:29]

Sounds good.

+  run_loop.RunUntilIdle();
+  EXPECT_FALSE(password_store->IsEmpty());
+
+  NavigateToFile("/password/password_xhr_submit.html");
+
+  // Let the user interact with the page, so that DOM gets modification events,
+  // needed for autofilling fields.
+  content::SimulateMouseClickAt(
+      WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+
+  // Wait until that interaction causes the password value to be revealed.
+  WaitForElementValue("password_field", "mypassword");
+}