Issue 1039813002: Update span dependency: this fixes an issue where span context didn't include

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1039813002: Update span dependency: this fixes an issue where span context didn't include (Closed)

Created:
5 years, 8 months ago by Siggi Cherem (dart-lang)

Modified:
5 years, 8 months ago

Reviewers:
Jacob

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update span dependency: this fixes an issue where span context didn't include the text R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/fece7ac750e922f10df9dd84fb3f0c2f8a1a9a2c

Patch Set 1 #

Total comments: 2

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pubspec.yaml	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jacob

lgtm https://codereview.chromium.org/1039813002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1039813002/diff/1/pubspec.yaml#newcode21 pubspec.yaml:21: source_span: ^1.1.1 why not any version of source_span ...

5 years, 8 months ago (2015-03-27 23:41:34 UTC) #3

Siggi Cherem (dart-lang)

Committed patchset #1 (id:1) manually as fece7ac750e922f10df9dd84fb3f0c2f8a1a9a2c (presubmit successful).

5 years, 8 months ago (2015-03-27 23:57:42 UTC) #4

Siggi Cherem (dart-lang)

5 years, 8 months ago (2015-03-30 20:05:45 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1039813002/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1039813002/diff/1/pubspec.yaml#newcode21
pubspec.yaml:21: source_span: ^1.1.1
On 2015/03/27 23:41:34, Jacob wrote:
> why not any version of source_span before 1.2?

We talked offline, but just to relay the info here: this is because there was a
bug fix and we now depend on that bug fix being there. An alternative for us is
to submit the pubspec.lock files.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages