Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1039783002: cc: Use const ref to avoid extra ref count of VideoProviderClientImpl. (Closed)

Created:
5 years, 9 months ago by sunnyps
Modified:
5 years, 9 months ago
Reviewers:
danakj
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Use const ref to avoid extra ref count of VideoProviderClientImpl. Use a const ref to avoid the expensive operation of incrementing the ref count of RefCountedThreadSafe VideoProviderClientImpl. BUG=336733 Committed: https://crrev.com/b9fe57c1d28a89abed11bf7e11dc7c03390e50af Cr-Commit-Position: refs/heads/master@{#322633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/layers/video_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/video_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sunnyps
PTAL.
5 years, 9 months ago (2015-03-27 18:58:03 UTC) #2
danakj
Sure. LGTM
5 years, 9 months ago (2015-03-27 19:01:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039783002/1
5 years, 9 months ago (2015-03-27 19:03:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 20:27:17 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 20:27:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9fe57c1d28a89abed11bf7e11dc7c03390e50af
Cr-Commit-Position: refs/heads/master@{#322633}

Powered by Google App Engine
This is Rietveld 408576698