Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1039763002: Cache Storage: Move files to content/*/cache_storage, rename classes (Closed)

Created:
5 years, 9 months ago by jsbell
Modified:
5 years, 8 months ago
CC:
chromium-reviews, tim+watch_chromium.org, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, zea+watch_chromium.org, tzik, maxbogue+watch_chromium.org, jam, kinuko+serviceworker, serviceworker-reviews, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, michaeln, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, kinuko+watch, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cache Storage: Move files to content/*/cache_storage, rename classes * Introduce content/*/cache_storage * Move Cache Storage files from content/*/service_worker * Update gypi/gn files * Rename classes, ipc messages, protobuf messages The renames are basically mechanical: * ServiceWorkerCacheStorageFoo -> CacheStorageFoo * ServiceWorkerCacheFoo -> CacheStorageFoo * ServiceWorkerCache -> CacheStorageCache (not just 'Cache') Also, made jkarlin@ and jsbell@ (that's me!) OWNERS in the new directories in addition to the */service_worker/OWNERS. BUG=439389 Committed: https://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a Cr-Commit-Position: refs/heads/master@{#323060}

Patch Set 1 #

Patch Set 2 : GN fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1729 lines, -8925 lines) Patch
M content/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/cache_storage/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/cache_storage/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/cache_storage/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/cache_storage/cache_storage.h View 12 chunks +40 lines, -41 lines 0 comments Download
A + content/browser/cache_storage/cache_storage.cc View 30 chunks +189 lines, -236 lines 0 comments Download
A + content/browser/cache_storage/cache_storage.proto View 2 chunks +11 lines, -13 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_cache.h View 10 chunks +25 lines, -24 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_cache.cc View 60 chunks +168 lines, -195 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_cache_unittest.cc View 38 chunks +106 lines, -135 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_context_impl.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_context_impl.cc View 3 chunks +6 lines, -7 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_dispatcher_host.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_dispatcher_host.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_listener.h View 4 chunks +53 lines, -58 lines 0 comments Download
A content/browser/cache_storage/cache_storage_listener.cc View 1 chunk +493 lines, -0 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_manager.h View 6 chunks +40 lines, -47 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_manager.cc View 16 chunks +64 lines, -85 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_manager_unittest.cc View 41 chunks +154 lines, -190 lines 0 comments Download
A content/browser/cache_storage/cache_storage_proto.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_quota_client.h View 3 chunks +12 lines, -13 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_quota_client.cc View 5 chunks +14 lines, -16 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_scheduler.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_scheduler.cc View 2 chunks +7 lines, -9 lines 0 comments Download
A + content/browser/cache_storage/cache_storage_scheduler_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/service_worker/cache_storage_context_impl.h View 1 chunk +0 lines, -87 lines 0 comments Download
D content/browser/service_worker/cache_storage_context_impl.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D content/browser/service_worker/cache_storage_dispatcher_host.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/browser/service_worker/cache_storage_dispatcher_host.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D content/browser/service_worker/service_worker_cache.h View 1 chunk +0 lines, -222 lines 0 comments Download
D content/browser/service_worker/service_worker_cache.cc View 1 chunk +0 lines, -1274 lines 0 comments Download
D content/browser/service_worker/service_worker_cache.proto View 1 chunk +0 lines, -48 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_listener.h View 1 chunk +0 lines, -185 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_listener.cc View 1 chunk +0 lines, -516 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_quota_client.h View 1 chunk +0 lines, -54 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_quota_client.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_scheduler.h View 1 chunk +0 lines, -43 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_scheduler.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_scheduler_unittest.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_storage.h View 1 chunk +0 lines, -235 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_storage.cc View 1 chunk +0 lines, -907 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_storage_manager.h View 1 chunk +0 lines, -166 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_storage_manager.cc View 1 chunk +0 lines, -385 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc View 1 chunk +0 lines, -841 lines 0 comments Download
D content/browser/service_worker/service_worker_cache_unittest.cc View 1 chunk +0 lines, -836 lines 0 comments Download
M content/browser/service_worker/service_worker_proto.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/storage_partition_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/common/cache_storage/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/common/cache_storage/cache_storage_messages.h View 4 chunks +39 lines, -38 lines 0 comments Download
A content/common/cache_storage/cache_storage_types.h View 1 chunk +52 lines, -0 lines 0 comments Download
A content/common/cache_storage/cache_storage_types.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M content/common/content_message_generator.h View 2 chunks +1 line, -1 line 0 comments Download
D content/common/service_worker/cache_storage_messages.h View 1 chunk +0 lines, -197 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 chunk +0 lines, -29 lines 0 comments Download
M content/common/service_worker/service_worker_types.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/content_browser.gypi View 3 chunks +17 lines, -16 lines 0 comments Download
M content/content_common.gypi View 2 chunks +3 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 3 chunks +6 lines, -6 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/cache_storage/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/renderer/cache_storage/cache_storage_dispatcher.h View 3 chunks +9 lines, -11 lines 0 comments Download
A + content/renderer/cache_storage/cache_storage_dispatcher.cc View 33 chunks +112 lines, -127 lines 0 comments Download
A + content/renderer/cache_storage/cache_storage_message_filter.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/renderer/cache_storage/cache_storage_message_filter.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/cache_storage/webserviceworkercachestorage_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/renderer/cache_storage/webserviceworkercachestorage_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
D content/renderer/service_worker/cache_storage_message_filter.h View 1 chunk +0 lines, -32 lines 0 comments Download
D content/renderer/service_worker/cache_storage_message_filter.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D content/renderer/service_worker/service_worker_cache_storage_dispatcher.h View 1 chunk +0 lines, -224 lines 0 comments Download
D content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc View 1 chunk +0 lines, -692 lines 0 comments Download
D content/renderer/service_worker/webserviceworkercachestorage_impl.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/renderer/service_worker/webserviceworkercachestorage_impl.cc View 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
jsbell
jkarlin@ - can you take a look and see if the naming makes sense to ...
5 years, 9 months ago (2015-03-27 21:52:33 UTC) #2
jkarlin
lgtm
5 years, 8 months ago (2015-03-30 12:53:13 UTC) #3
jsbell
tsepez@ - can you review the messaging changes? (just file move/message renames) jam@ - can ...
5 years, 8 months ago (2015-03-30 16:26:41 UTC) #5
Tom Sepez
RS LGTM on renames.
5 years, 8 months ago (2015-03-30 18:58:00 UTC) #6
jam
rubberstamp lgtm
5 years, 8 months ago (2015-03-30 21:10:38 UTC) #7
kinuko
On 2015/03/30 16:26:41, jsbell wrote: > tsepez@ - can you review the messaging changes? (just ...
5 years, 8 months ago (2015-03-31 02:13:44 UTC) #8
nhiroki
On 2015/03/31 02:13:44, kinuko wrote: > On 2015/03/30 16:26:41, jsbell wrote: > > tsepez@ - ...
5 years, 8 months ago (2015-03-31 04:44:32 UTC) #9
horo
lgtm
5 years, 8 months ago (2015-03-31 15:38:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039763002/20001
5 years, 8 months ago (2015-03-31 16:04:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 17:02:59 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 17:03:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/279efb4de2d891d4575329c853e1c9858c057d2a
Cr-Commit-Position: refs/heads/master@{#323060}

Powered by Google App Engine
This is Rietveld 408576698