Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1039753002: [turbofan][arm64] Use immediates instead of MiscField for stack operations. (Closed)

Created:
5 years, 9 months ago by baptiste.afsa1
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan][arm64] Use immediates instead of MiscField for stack operations. This avoid to depend on MiscField to be big enough to hold the offset/size. This patch also remove the Arm64PokePair which is no longer used. R=bmeurer@chromium.org Committed: https://crrev.com/6ad9bc2f55f0cb13927808be41855cb7b3c4fbcf Cr-Commit-Position: refs/heads/master@{#27505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
baptiste.afsa1
PTAL
5 years, 9 months ago (2015-03-27 17:23:24 UTC) #1
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-27 18:20:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039753002/1
5 years, 9 months ago (2015-03-27 18:21:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 21:57:46 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 21:57:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ad9bc2f55f0cb13927808be41855cb7b3c4fbcf
Cr-Commit-Position: refs/heads/master@{#27505}

Powered by Google App Engine
This is Rietveld 408576698