Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1039733003: This fixes missing incremental write barrier issue when double fields unboxing is enabled. (Closed)

Created:
5 years, 8 months ago by Igor Sheludko
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

This fixes missing incremental write barrier issue when double fields unboxing is enabled. This CL also adds useful machinery that helps triggering incremental write barriers. BUG=chromium:469146 LOG=Y Committed: https://crrev.com/9d2d8a9c8d87c35fbc5aacc16f87f2846a2896d4 Cr-Commit-Position: refs/heads/master@{#27503}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -59 lines) Patch
M src/flag-definitions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 3 chunks +18 lines, -17 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 5 chunks +121 lines, -38 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Igor Sheludko
PTAL
5 years, 8 months ago (2015-03-27 20:30:32 UTC) #3
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-03-27 21:29:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039733003/20001
5 years, 8 months ago (2015-03-27 21:29:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 8 months ago (2015-03-27 21:55:32 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-03-27 21:55:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d2d8a9c8d87c35fbc5aacc16f87f2846a2896d4
Cr-Commit-Position: refs/heads/master@{#27503}

Powered by Google App Engine
This is Rietveld 408576698