Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1039733002: Add Robolectric unittest suites to all.gyp and rename build targets. (Closed)

Created:
5 years, 9 months ago by mikecase (-- gone --)
Modified:
5 years, 8 months ago
Reviewers:
Ted C, cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Robolectric unittest suites to all.gyp and rename build targets. Renaming chrome_shell_unit_tests to chrome_junit_tests as it tests code in the directory of the chrome_java target (and not the chrome_shell_java target). Same thing for content_shell_unit_tests. And adding chrome_junit_tests and content_junit_tests to the all.gyp file so we can run the tests on some of the bots. BUG= Committed: https://crrev.com/e240ab4e9c5841de8cb65226a80008600416c365 Cr-Commit-Position: refs/heads/master@{#322813}

Patch Set 1 #

Patch Set 2 : Renaming Robolectric unit test build targets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M build/all.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mikecase (-- gone --)
5 years, 9 months ago (2015-03-27 16:32:56 UTC) #2
cjhopman
lgtm
5 years, 9 months ago (2015-03-29 02:09:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039733002/20001
5 years, 8 months ago (2015-03-30 16:05:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/52638)
5 years, 8 months ago (2015-03-30 16:15:33 UTC) #7
mikecase (-- gone --)
5 years, 8 months ago (2015-03-30 16:30:36 UTC) #9
Ted C
lgtm
5 years, 8 months ago (2015-03-30 17:56:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039733002/20001
5 years, 8 months ago (2015-03-30 18:06:34 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-30 18:14:54 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 18:15:24 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e240ab4e9c5841de8cb65226a80008600416c365
Cr-Commit-Position: refs/heads/master@{#322813}

Powered by Google App Engine
This is Rietveld 408576698