Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Issue 1039543003: [DevTools] Move network protocol handler to RenderFrameHost. (Closed)

Created:
5 years, 9 months ago by dgozman
Modified:
5 years, 8 months ago
Reviewers:
jam, boliu, yurys
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, android-webview-reviews_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move network protocol handler to RenderFrameHost. BUG=470453 Committed: https://crrev.com/d98dbc8d825496fd196db931dddf83c3945ff4b9 Cr-Commit-Position: refs/heads/master@{#322601}

Patch Set 1 #

Patch Set 2 : fix android_webview compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/network_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/protocol/network_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
dgozman
Could you please take a look? @jam: please review content/public and chrome/ @boliu: please review ...
5 years, 9 months ago (2015-03-27 13:06:18 UTC) #2
yurys
content/browser/devtools - lgtm
5 years, 8 months ago (2015-03-27 13:26:07 UTC) #3
boliu
android_webview lgtm
5 years, 8 months ago (2015-03-27 14:19:46 UTC) #4
jam
lgtm
5 years, 8 months ago (2015-03-27 16:05:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039543003/1
5 years, 8 months ago (2015-03-27 16:07:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/1067) linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 8 months ago (2015-03-27 16:48:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039543003/20001
5 years, 8 months ago (2015-03-27 16:59:20 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-27 17:52:08 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-03-27 17:53:03 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d98dbc8d825496fd196db931dddf83c3945ff4b9
Cr-Commit-Position: refs/heads/master@{#322601}

Powered by Google App Engine
This is Rietveld 408576698