Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: cc/scheduler/scheduler_state_machine.cc

Issue 1039533002: cc: Add support for sending BeginFrames for video. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@misc_video_refactoring
Patch Set: Remove visibility updates. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/scheduler_state_machine.cc
diff --git a/cc/scheduler/scheduler_state_machine.cc b/cc/scheduler/scheduler_state_machine.cc
index 960cdd0fee400214460fc9120686033d748f1f64..876cafb61ce566d9a6b3291d6a46064f9589a611 100644
--- a/cc/scheduler/scheduler_state_machine.cc
+++ b/cc/scheduler/scheduler_state_machine.cc
@@ -52,6 +52,7 @@ SchedulerStateMachine::SchedulerStateMachine(const SchedulerSettings& settings)
continuous_painting_(false),
children_need_begin_frames_(false),
defer_commits_(false),
+ video_needs_begin_frames_(false),
last_commit_had_no_updates_(false),
wait_for_active_tree_ready_to_draw_(false),
did_request_swap_in_last_frame_(false),
@@ -243,6 +244,7 @@ void SchedulerStateMachine::AsValueInto(
skip_next_begin_main_frame_to_reduce_latency_);
state->SetBoolean("continuous_painting", continuous_painting_);
state->SetBoolean("children_need_begin_frames", children_need_begin_frames_);
+ state->SetBoolean("video_needs_begin_frames", video_needs_begin_frames_);
state->SetBoolean("defer_commits", defer_commits_);
state->SetBoolean("last_commit_had_no_updates", last_commit_had_no_updates_);
state->SetBoolean("did_request_swap_in_last_frame",
@@ -715,6 +717,9 @@ void SchedulerStateMachine::SetSkipNextBeginMainFrameToReduceLatency() {
bool SchedulerStateMachine::BeginFrameRequiredForChildren() const {
return children_need_begin_frames_;
}
+bool SchedulerStateMachine::BeginFrameNeededForVideo() const {
+ return video_needs_begin_frames_;
+}
bool SchedulerStateMachine::BeginFrameNeeded() const {
// We can't handle BeginFrames when output surface isn't initialized.
@@ -727,7 +732,7 @@ bool SchedulerStateMachine::BeginFrameNeeded() const {
return false;
return (BeginFrameRequiredForAction() || BeginFrameRequiredForChildren() ||
- ProactiveBeginFrameWanted());
+ BeginFrameNeededForVideo() || ProactiveBeginFrameWanted());
brianderson 2015/04/16 01:42:23 To confirm: Video doesn't need BeginFrames when th
sunnyps 2015/04/16 20:56:11 Yes, video doesn't need BeginFrames when the rende
}
void SchedulerStateMachine::SetChildrenNeedBeginFrames(
@@ -735,6 +740,11 @@ void SchedulerStateMachine::SetChildrenNeedBeginFrames(
children_need_begin_frames_ = children_need_begin_frames;
}
+void SchedulerStateMachine::SetVideoNeedsBeginFrames(
+ bool video_needs_begin_frames) {
+ video_needs_begin_frames_ = video_needs_begin_frames;
+}
+
void SchedulerStateMachine::SetDeferCommits(bool defer_commits) {
defer_commits_ = defer_commits;
}

Powered by Google App Engine
This is Rietveld 408576698