Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1039513003: Make DocumentTabModelImpl fire didSelectTab (Closed)

Created:
5 years, 9 months ago by gone
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DocumentTabModelImpl fire didSelectTab DocumentTabModelImpl now fires didSelectTab to its observers. This is done in setLastShownId() instead of setIndex() for a few reasons: * setIndex() has the side effect of bringing Tabs forward, which you may not want. * setLastShownId() hopefully more faithfully tracks what Tab was last shown in the foreground, and is called by DocumentActivity.onResume(). This might still be incorrect (e.g. when opening a Tab in the background), but this is one of those weird cases where Android has two Activities in the foreground simultaneously. * It's really difficult to actually indicate what brings a Tab back to the foreground. Slap a TODO on there to actually fix it when an Observer actually needs to know the type. BUG=443772 Committed: https://crrev.com/b265913295783b977eb6aa7294ebcb938cd8bf62 Cr-Commit-Position: refs/heads/master@{#322519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModel.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java View 2 chunks +13 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/OffTheRecordDocumentTabModel.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
gone
5 years, 9 months ago (2015-03-27 00:23:22 UTC) #2
Ted C
lgtm
5 years, 9 months ago (2015-03-27 00:30:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039513003/1
5 years, 9 months ago (2015-03-27 01:30:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 01:55:48 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 01:56:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b265913295783b977eb6aa7294ebcb938cd8bf62
Cr-Commit-Position: refs/heads/master@{#322519}

Powered by Google App Engine
This is Rietveld 408576698