Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 1039473003: A number of fixes to please clang_tidy. There should be no functional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Move_test_for_incoming_packets_89336249
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_packet_creator.cc ('k') | net/tools/quic/quic_time_wait_list_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index d4684a1d6a2d3a6cb0d68a7e9d90d570617f7d88..d63977e741605a5addd9d1759253c2c199ba325c 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -741,7 +741,7 @@ TEST_P(EndToEndTest, DoNotSetResumeWriteAlarmIfConnectionFlowControlBlocked) {
// Ensure both stream and connection level are flow control blocked by setting
// the send window offset to 0.
- const uint64 kFlowControlWindow =
+ const uint64 flow_control_window =
server_config_.GetInitialStreamFlowControlWindowToSend();
QuicSpdyClientStream* stream = client_->GetOrCreateStream();
QuicSession* session = client_->client()->session();
@@ -756,7 +756,7 @@ TEST_P(EndToEndTest, DoNotSetResumeWriteAlarmIfConnectionFlowControlBlocked) {
// The stream now attempts to write, fails because it is still connection
// level flow control blocked, and is added to the write blocked list.
- QuicWindowUpdateFrame window_update(stream->id(), 2 * kFlowControlWindow);
+ QuicWindowUpdateFrame window_update(stream->id(), 2 * flow_control_window);
stream->OnWindowUpdateFrame(window_update);
// Prior to fixing b/14677858 this call would result in an infinite loop in
« no previous file with comments | « net/quic/quic_packet_creator.cc ('k') | net/tools/quic/quic_time_wait_list_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698