Issue 1039473003: A number of fixes to please clang_tidy. There should be no functional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1039473003: A number of fixes to please clang_tidy. There should be no functional (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Move_test_for_incoming_packets_89336249

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

A number of fixes to please clang_tidy. There should be no functional changes. Putting the construction of a "null" SerializedPacket into a function rather than constructing one into a local variable everywhere one is needed. Renaming class members to end with "_". Taking the initial "k" off local variables. Merge internal change: 89397417 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -20 lines)			Patch
M	net/quic/quic_packet_creator.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	4 chunks	+7 lines, -9 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_time_wait_list_manager_test.cc	View	2 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages