Issue 103943004: Fixes bench_util's CONFIG_RE to cope with space flexibility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 103943004: Fixes bench_util's CONFIG_RE to cope with space flexibility. (Closed)

Created:
7 years ago by benchen

Modified:
7 years ago

Reviewers:
Stephen White, senorblanco

CC:
skia-review_googlegroups.com, skiabot_google.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Fixes bench_util's CONFIG_RE to cope with space flexibility. The real "fix" down the road is Joe's ongoing work of switching to JSON. Committed: https://code.google.com/p/skia/source/detail?r=12498

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	bench/bench_util.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

benchen

I think this will fix bench_compare as well. On my database data collection side, I ...

7 years ago (2013-12-05 01:29:32 UTC) #1

benchen

correction: the main diff (one-line CONFIG_RE) is the same in the google3 CL. Comments will ...

7 years ago (2013-12-05 01:31:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r12498 (presubmit successful).