Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1039423002: Merge: Fix glGetActiveUniform/Attrib crashes due to state inconsistency (Closed)

Created:
5 years, 9 months ago by Will Harris
Modified:
5 years, 9 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Merge: Fix glGetActiveUniform/Attrib crashes due to state inconsistency between what Chrome thinks and what the driver is. This is caused by we intercept invalid program and generate an error on LinkProgram rather than passing it to the driver, so the driver still have a valid program if the previous link succeeds. BUG=463599 TEST=test case in the bug R=sievers@chromium.org Review URL: https://codereview.chromium.org/978193003 Cr-Commit-Position: refs/heads/master@{#319746} (cherry picked from commit 44ad5ecc3abf8f31d7e55a9ece5cea30a710fd77) Committed: https://chromium.googlesource.com/chromium/src/+/73f24f1ef5e222566a84070887eb5120cdef55e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M gpu/blink/webgraphicscontext3d_impl.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Will Harris
5 years, 9 months ago (2015-03-27 22:33:01 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
73f24f1ef5e222566a84070887eb5120cdef55e8.

Powered by Google App Engine
This is Rietveld 408576698