Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 103933002: Use constant types to represent the fixed right arg of a MOD. (Closed)

Created:
7 years ago by Benedikt Meurer
Modified:
7 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Use constant types to represent the fixed right arg of a MOD. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -59 lines) Patch
M src/ast.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +29 lines, -31 lines 0 comments Download
M src/ic.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/ic.cc View 2 chunks +15 lines, -1 line 0 comments Download
M src/type-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Next try...
7 years ago (2013-12-04 08:28:52 UTC) #1
Sven Panne
lgtm
7 years ago (2013-12-04 08:32:12 UTC) #2
Benedikt Meurer
7 years ago (2013-12-04 08:37:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18246 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698