Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1039303002: Whitelist all Mali-400 for canvas/GPU raster except known bad models. (Closed)

Created:
5 years, 9 months ago by aelias_OOO_until_Jul13
Modified:
5 years, 8 months ago
Reviewers:
no sievers
CC:
bsalomon_chromium, chromium-reviews, piman+watch_chromium.org, Vangelis Kokkevis, vmiura, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist all Mali-400 for canvas/GPU raster except known bad models. Most Mali-400 we've tested seem to have reasonable quality drivers, but there are a few bad apples. The Galaxy S3 Mini (GT-I8190N) I can repro corruption locally on. Also (though I've failed to locally repro issues with the following): we had past reports of problems on Galaxy S3 (GT-I9300) and Galaxy Note 2 (SPH-L900), and also reports of non-GPU-raster corruption issues on Galaxy S5 Mini (SM-G800F). Let's try to ship a whitelist expansion excluding specifically those. It's likely I'll need to add some more long-tail devices to this list based on user bug reports. BUG=451230, 468808 Committed: https://crrev.com/a7d16cadb7ca6e8d505ae37be437a4ad103d51bc Cr-Commit-Position: refs/heads/master@{#323150}

Patch Set 1 #

Patch Set 2 : Use right name for Mali Galaxy Note 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M gpu/config/software_rendering_list_json.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
aelias_OOO_until_Jul13
PTAL.
5 years, 9 months ago (2015-03-27 17:43:36 UTC) #2
aelias_OOO_until_Jul13
Since zmo@ is on vacation, adding sievers@ for OWNERS review instead.
5 years, 8 months ago (2015-03-31 02:47:39 UTC) #4
no sievers
lgtm
5 years, 8 months ago (2015-03-31 18:39:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039303002/20001
5 years, 8 months ago (2015-03-31 23:11:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-01 00:08:09 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 00:09:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7d16cadb7ca6e8d505ae37be437a4ad103d51bc
Cr-Commit-Position: refs/heads/master@{#323150}

Powered by Google App Engine
This is Rietveld 408576698