Issue 1039263003: Prevent integer overflow when (de)serializing BackoffEntry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1039263003: Prevent integer overflow when (de)serializing BackoffEntry

Created:
5 years, 9 months ago by johnme

Modified:
5 years, 9 months ago

Reviewers:
davidben

CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Sleevi

Base URL:
https://chromium.googlesource.com/chromium/src.git@backoff

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Prevent integer overflow when (de)serializing BackoffEntry DEPENDS ON https://codereview.chromium.org/1023473003 Patch https://codereview.chromium.org/1023473003/ added methods for the serialization/deserialization of BackoffEntrys, but they are vulnerable to integer overflow. This patch makes the implementation never overflow; instead, times will be clamped to the nearest representable time. BUG=465399

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -16 lines)			Patch
	M	net/base/backoff_entry.cc	View		2 chunks	+31 lines, -13 lines	0 comments	Download
	M	net/base/backoff_entry_unittest.cc	View		4 chunks	+130 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

johnme

See also similar issue https://codereview.chromium.org/337803004 in the past.

5 years, 9 months ago (2015-03-27 20:11:09 UTC) #2

Ryan Sleevi

5 years, 9 months ago (2015-03-27 20:27:28 UTC) #4

Still noting my general unease at this; I don't think this belongs in
BackoffEntry

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages