//net changes for stale-while-revalidate

net/http/http_cache_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_cache_transaction.h"
 
 #include "build/build_config.h"  // For OS_POSIX
 
 #if defined(OS_POSIX)
 #include <unistd.h>
@@ skipping 2097 matching lines @@
   return OK;
 }
 
 int HttpCache::Transaction::BeginCacheValidation() {
   DCHECK_EQ(mode_, READ_WRITE);
 
   ValidationType required_validation = RequiresValidation();
 
   bool skip_validation = (required_validation == VALIDATION_NONE);
 
+  if ((effective_load_flags_ & LOAD_SUPPORT_ASYNC_REVALIDATION) &&
+      required_validation == VALIDATION_ASYNCHRONOUS) {
+    DCHECK_EQ("GET", request_->method);

[rvargas (doing something else), 2015/08/20 22:26:29]

nit: dchecks should read as an if, not as an EXPECT (aka, invert the order)

[Adam Rice, 2015/08/21 15:01:46]

I didn't realise that, thank you.

+    skip_validation = true;
+    response_.async_revalidation_required = true;
+  }
+
   if (request_->method == "HEAD" &&
       (truncated_ || response_.headers->response_code() == 206)) {
     DCHECK(!partial_);
     if (skip_validation)
       return SetupEntryForRead();
 
     // Bail out!
     next_state_ = STATE_SEND_REQUEST;
     mode_ = NONE;
     return OK;
@@ skipping 107 matching lines @@
     }
   }
 
   // TODO(ricea): This calculation is expensive to perform just to collect
   // statistics. Either remove it or use the result, depending on the result of
   // the experiment.
   ExternallyConditionalizedType type =
       EXTERNALLY_CONDITIONALIZED_CACHE_USABLE;
   if (mode_ == NONE)
     type = EXTERNALLY_CONDITIONALIZED_MISMATCHED_VALIDATORS;
-  else if (RequiresValidation())
+  else if (RequiresValidation() != VALIDATION_NONE)
     type = EXTERNALLY_CONDITIONALIZED_CACHE_REQUIRES_VALIDATION;
 
   // TODO(ricea): Add CACHE_USABLE_STALE once stale-while-revalidate CL landed.
   // TODO(ricea): Either remove this histogram or make it permanent by M40.
   UMA_HISTOGRAM_ENUMERATION("HttpCache.ExternallyConditionalized",
                             type,
                             EXTERNALLY_CONDITIONALIZED_MAX);
 
   next_state_ = STATE_SEND_REQUEST;
   return OK;
@@ skipping 662 matching lines @@
     default:
       NOTREACHED();
   }
 }
 
 void HttpCache::Transaction::OnIOComplete(int result) {
   DoLoop(result);
 }
 
 }  // namespace net