Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1039263002: //net changes for stale-while-revalidate (Closed)

Created:
5 years, 9 months ago by Adam Rice
Modified:
5 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@s-w-r-remove-old-impl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//net changes for stale-while-revalidate Add load flag LOAD_SUPPORT_ASYNC_REVALIDATION, HttpResponseInfo flag async_revalidation_required and logic to HttpCache::Transaction to use them. See the design doc at https://docs.google.com/a/chromium.org/document/d/1nBhr25nSJgoyAh4S1-U5h2sH70Iz4RR0NAfXNL79G5Y/edit BUG=348877 TEST=net_unittests Committed: https://crrev.com/8bad09d9dd4d3de03c877a22c7c309454e219670 Cr-Commit-Position: refs/heads/master@{#345037}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Renumber LOAD_SUPPORT_ASYNC_REVALIDATION. #

Total comments: 2

Patch Set 4 : Only support GET for async revalidations. #

Total comments: 4

Patch Set 5 : Fixes from tyoshino review. #

Patch Set 6 : Rebase and add tests to http_cache_unittest.cc. #

Patch Set 7 : Rebase. #

Patch Set 8 : Replace EXPECT_EQ(bool, v) with EXPECT_BOOL(v) #

Patch Set 9 : Rebase. #

Patch Set 10 : Rebase. #

Total comments: 6

Patch Set 11 : Changes suggested by rvargas. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -5 lines) Patch
M net/base/load_flags_list.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +8 lines, -1 line 0 comments Download
M net/http/http_cache_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +77 lines, -0 lines 0 comments Download
M net/http/http_response_info.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M net/http/http_response_info.cc View 1 2 3 4 5 6 7 4 chunks +5 lines, -4 lines 0 comments Download
M net/http/http_response_info_unittest.cc View 1 2 3 4 5 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (4 generated)
Adam Rice
5 years, 6 months ago (2015-06-01 10:38:34 UTC) #2
hiroshige
https://codereview.chromium.org/1039263002/diff/40001/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/1039263002/diff/40001/net/http/http_cache_transaction.cc#newcode2124 net/http/http_cache_transaction.cc:2124: DCHECK(request_->method == "HEAD" || request_->method == "GET"); The doc ...
5 years, 6 months ago (2015-06-12 05:58:03 UTC) #3
Adam Rice
https://codereview.chromium.org/1039263002/diff/40001/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/1039263002/diff/40001/net/http/http_cache_transaction.cc#newcode2124 net/http/http_cache_transaction.cc:2124: DCHECK(request_->method == "HEAD" || request_->method == "GET"); On 2015/06/12 ...
5 years, 6 months ago (2015-06-12 06:41:57 UTC) #4
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/1039263002/diff/60001/net/base/load_flags_list.h File net/base/load_flags_list.h (right): https://codereview.chromium.org/1039263002/diff/60001/net/base/load_flags_list.h#newcode91 net/base/load_flags_list.h:91: // by the Cache-Control: stale-while-revalidate directive and is able ...
5 years, 6 months ago (2015-06-15 09:40:02 UTC) #6
Adam Rice
https://codereview.chromium.org/1039263002/diff/60001/net/base/load_flags_list.h File net/base/load_flags_list.h (right): https://codereview.chromium.org/1039263002/diff/60001/net/base/load_flags_list.h#newcode91 net/base/load_flags_list.h:91: // by the Cache-Control: stale-while-revalidate directive and is able ...
5 years, 6 months ago (2015-06-15 10:17:41 UTC) #7
Adam Rice
tyoshino, PTAL at the tests I added to http_cache_unittests.cc. Thanks.
5 years, 6 months ago (2015-06-19 14:38:18 UTC) #8
Adam Rice
tyoshino: ping. Does this look okay?
5 years, 4 months ago (2015-08-14 20:24:14 UTC) #9
Adam Rice
+rvargas, do you have time to take a look?
5 years, 4 months ago (2015-08-18 16:11:28 UTC) #10
mmenke
On 2015/08/18 16:11:28, Adam Rice wrote: > +rvargas, do you have time to take a ...
5 years, 4 months ago (2015-08-20 16:13:33 UTC) #11
Adam Rice
+rvargas for real this time.
5 years, 4 months ago (2015-08-20 16:30:52 UTC) #13
rvargas (doing something else)
https://codereview.chromium.org/1039263002/diff/180001/net/base/load_flags_list.h File net/base/load_flags_list.h (right): https://codereview.chromium.org/1039263002/diff/180001/net/base/load_flags_list.h#newcode88 net/base/load_flags_list.h:88: LOAD_FLAG(SUPPORT_ASYNC_REVALIDATION, 1 << 19) Why skip 18? https://codereview.chromium.org/1039263002/diff/180001/net/http/http_cache_transaction.cc File ...
5 years, 4 months ago (2015-08-20 22:26:29 UTC) #14
Adam Rice
https://codereview.chromium.org/1039263002/diff/180001/net/base/load_flags_list.h File net/base/load_flags_list.h (right): https://codereview.chromium.org/1039263002/diff/180001/net/base/load_flags_list.h#newcode88 net/base/load_flags_list.h:88: LOAD_FLAG(SUPPORT_ASYNC_REVALIDATION, 1 << 19) On 2015/08/20 22:26:28, rvargas wrote: ...
5 years, 4 months ago (2015-08-21 15:01:47 UTC) #15
rvargas (doing something else)
lgtm
5 years, 4 months ago (2015-08-21 18:13:00 UTC) #16
tyoshino (SeeGerritForStatus)
lgtm
5 years, 4 months ago (2015-08-24 07:09:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039263002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1039263002/200001
5 years, 4 months ago (2015-08-24 07:40:43 UTC) #19
commit-bot: I haz the power
Committed patchset #11 (id:200001)
5 years, 4 months ago (2015-08-24 09:01:56 UTC) #20
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 09:02:46 UTC) #21
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/8bad09d9dd4d3de03c877a22c7c309454e219670
Cr-Commit-Position: refs/heads/master@{#345037}

Powered by Google App Engine
This is Rietveld 408576698