Issue 1039253002: Minor cleanup in nanobench

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1039253002: Minor cleanup in nanobench (Closed)

Created:
5 years, 9 months ago by tomhudson

Modified:
5 years, 9 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Minor cleanup in nanobench Simplify time() by removing conditionals; reduce the amount of parameter passing. Add a convenience function to Target. R=mtklein@google.com BUG=skia:3595 Committed: https://skia.googlesource.com/skia/+/75a0ebb0d0bd852e3b068bf14370c6689242a89c

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -28 lines)			Patch
	M	bench/nanobench.h	View		2 chunks	+9 lines, -1 line	0 comments	Download
	M	bench/nanobench.cpp	View	1	11 chunks	+21 lines, -27 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039253002/20001

5 years, 9 months ago (2015-03-27 16:25:46 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-27 19:11:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/75a0ebb0d0bd852e3b068bf14370c6689242a89c