Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 103923002: Speed up generateImage by re-using the outline/bitmap that has already been loaded. (Closed)

Created:
7 years ago by zheng.xu
Modified:
6 years, 12 months ago
Reviewers:
bungeman-skia, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Speed up generateImage by re-using the outline/bitmap that has already been loaded. SkDrawText need to query both glyph metrics and image in most cases. But to query metrics and image separately will duplicate the work to load glyph outline which is time consuming especially for composite glyphs. This patch record what is in the FreeType glyph slot and tries to re-use it. It get about 15% speed increasment with bench case fontscaler_lcd and fontscaler_aa (should be better for composite glyphs) BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -41 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 15 chunks +73 lines, -29 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.cpp View 4 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zheng.xu
7 years ago (2013-12-04 08:24:02 UTC) #1
reed1
Interesting patch. I will need some time to think about it. Can you land the ...
7 years ago (2013-12-04 14:59:38 UTC) #2
bungeman-skia
7 years ago (2013-12-04 15:46:59 UTC) #3
Note that I'm planning on landing bitmap font support soon, so many things will
change shortly. Hard to tell how that will affect this, I'll take a look at this
as soon as I have a handle on that.

Powered by Google App Engine
This is Rietveld 408576698