Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1039213002: DevTools: NetworkConditionsEmulation: fix interpretation of incorrect settings. (Closed)

Created:
5 years, 9 months ago by eustas
Modified:
5 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: NetworkConditionsEmulation: fix interpretation of incorrect settings. BUG=456324 Committed: https://crrev.com/96a3b4c52765cdbe28329c972efb07bcc75c372a Cr-Commit-Position: refs/heads/master@{#322568}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/devtools/devtools_network_conditions.cc View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
eustas
5 years, 9 months ago (2015-03-27 11:05:49 UTC) #2
dgozman
https://codereview.chromium.org/1039213002/diff/1/chrome/browser/devtools/devtools_network_conditions.cc File chrome/browser/devtools/devtools_network_conditions.cc (right): https://codereview.chromium.org/1039213002/diff/1/chrome/browser/devtools/devtools_network_conditions.cc#newcode38 chrome/browser/devtools/devtools_network_conditions.cc:38: return !offline_ && ((latency_ != 0) || (download_throughput_ != ...
5 years, 9 months ago (2015-03-27 11:42:35 UTC) #3
dgozman
lgtm
5 years, 9 months ago (2015-03-27 12:18:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039213002/1
5 years, 9 months ago (2015-03-27 12:29:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 13:26:42 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 13:27:27 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/96a3b4c52765cdbe28329c972efb07bcc75c372a
Cr-Commit-Position: refs/heads/master@{#322568}

Powered by Google App Engine
This is Rietveld 408576698