Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: utils/compiler/build_helper.dart

Issue 10392023: Change dart:io to use Future for one-shot operations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Adding stable test binaries Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_suite.dart ('k') | utils/pub/io.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/compiler/build_helper.dart
diff --git a/utils/compiler/build_helper.dart b/utils/compiler/build_helper.dart
index 3a01a65e4ede8b31ca5f9c9b315569b2241639be..78dd6c8e39d058dcf3f99fe154e67bfa25422e9c 100644
--- a/utils/compiler/build_helper.dart
+++ b/utils/compiler/build_helper.dart
@@ -51,14 +51,14 @@ writeScript(Uri uri, List<String> scripts) {
}
if (Platform.operatingSystem != 'windows') {
- onExit(int exitCode, String stdout, String stderr) {
- if (exitCode != 0) {
- print(stdout);
- print(stderr);
- exit(exitCode);
+ onExit(ProcessResult result) {
+ if (result.exitCode != 0) {
+ print(result.stdout);
+ print(result.stderr);
+ exit(result.exitCode);
}
}
- new Process.run('/bin/chmod', ['+x', uri.path], null, onExit);
+ Process.run('/bin/chmod', ['+x', uri.path]).then(onExit);
}
}
« no previous file with comments | « tools/testing/dart/test_suite.dart ('k') | utils/pub/io.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698