Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1039193002: Oilpan: Build fix after r192665 (Closed)

Created:
5 years, 9 months ago by haraken
Modified:
5 years, 9 months ago
Reviewers:
tkent, oilpan-reviews, sof
CC:
blink-reviews, Raymond Toy
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Build fix after r192665 TBR=tkent@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/modules/webaudio/AudioBasicProcessorNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
haraken
5 years, 9 months ago (2015-03-27 10:02:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039193002/1
5 years, 9 months ago (2015-03-27 10:03:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=192668
5 years, 9 months ago (2015-03-27 10:04:25 UTC) #5
sof
lgtm
5 years, 9 months ago (2015-03-27 10:07:53 UTC) #7
tkent
lgtm. Thank you. I wonder why the gc plugin didn't detect this error.
5 years, 9 months ago (2015-03-27 10:23:25 UTC) #8
sof
5 years, 9 months ago (2015-03-27 10:38:20 UTC) #9
Message was sent while issue was closed. 
On 2015/03/27 10:23:25, tkent wrote:
> lgtm.  Thank you.
> 
> I wonder why the gc plugin didn't detect this error.

It probably could be made to for OwnPtr<> tracing iff Oilpan is enabled. Would
get a better error message that way.

Powered by Google App Engine
This is Rietveld 408576698