Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1039163002: Re-enabling 720p webcam test for QTKit on Mac. (Closed)

Created:
5 years, 9 months ago by phoglund_chromium
Modified:
5 years, 9 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, mcasas
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enabling 720p webcam test for QTKit on Mac. mcasas tested it and it appears to work now. BUG=440762 Committed: https://crrev.com/6ad0306bf6039949bf7a572b07a839a3e6cd1ebb Cr-Commit-Position: refs/heads/master@{#322572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/media/chrome_webrtc_webcam_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
phoglund_chromium
5 years, 9 months ago (2015-03-27 08:55:34 UTC) #2
perkj_chrome
lgtm
5 years, 9 months ago (2015-03-27 09:23:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039163002/1
5 years, 9 months ago (2015-03-27 13:18:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 14:11:55 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6ad0306bf6039949bf7a572b07a839a3e6cd1ebb Cr-Commit-Position: refs/heads/master@{#322572}
5 years, 9 months ago (2015-03-27 14:13:05 UTC) #7
tommi (sloooow) - chröme
5 years, 8 months ago (2015-04-03 19:29:22 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1059163003/ by tommi@chromium.org.

The reason for reverting is: Doesn't look fixed.  This has been consistently
failing since landing, here:

https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester?numbuilds=200.

Powered by Google App Engine
This is Rietveld 408576698