chrome/browser/extensions/api/app/app_api.cc - Issue 10391034: Scaffolding for an experimental discovery API letting users inject links in the recommended pane of…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app/app_api.cc

Issue 10391034: Scaffolding for an experimental discovery API letting users inject links in the recommended pane of… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Answered review comments from PatchSet 4. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/app/app_api.cc

diff --git a/chrome/browser/extensions/api/app/app_api.cc b/chrome/browser/extensions/api/app/app_api.cc

index d429710f0fb7355c0a083c9e8da9509cbc7178bc..14c9ece19c78f06e6fc2920ce06a6d1f97a475d2 100644

--- a/chrome/browser/extensions/api/app/app_api.cc

+++ b/chrome/browser/extensions/api/app/app_api.cc

@@ -86,6 +86,7 @@ bool AppNotifyFunction::RunImpl() {

AppNotificationManager* manager =

profile()->GetExtensionService()->app_notification_manager();

+ // TODO(beaudoin) We should probably report an error if Add returns false.

manager->Add(item.release());

return true;

« no previous file with comments | « chrome/browser/extensions/api/README.txt ('k') | chrome/browser/extensions/api/discovery/discovery_api.h » ('j') | no next file with comments »