Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1039083004: Add remaining remoting targets for the GN build. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@content_browsertests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add remaining remoting targets for the GN build. R=brettw@chromium.org, garykac@chromium.org BUG=461019 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/ce5eb83716e16f5b92e766ea95c70d2ed1b9ec17 Cr-Commit-Position: refs/heads/master@{#323314}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add bug numbers for remaining tasks for remoting #

Patch Set 3 : merge to #322930 #

Patch Set 4 : add missing dependencies on libjingle_webrtc to fix the component build #

Patch Set 5 : merge to #323238 #

Patch Set 6 : disable remoting_host on mac, win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -13 lines) Patch
M BUILD.gn View 1 2 3 4 5 3 chunks +17 lines, -3 lines 0 comments Download
M build/config/linux/gtk/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 2 3 4 5 3 chunks +13 lines, -8 lines 0 comments Download
M remoting/BUILD.gn View 1 2 3 4 2 chunks +77 lines, -2 lines 0 comments Download
M remoting/host/BUILD.gn View 1 2 3 4 2 chunks +73 lines, -0 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 1 2 3 2 chunks +31 lines, -0 lines 0 comments Download
A remoting/remoting_host.gni View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
M remoting/remoting_host.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Dirk Pranke
fyi, though this isn't quite ready for review yet. I need to do another pass ...
5 years, 9 months ago (2015-03-27 03:17:42 UTC) #2
Dirk Pranke
Okay, I've pruned the webapp and a couple of other things out to separate bugs. ...
5 years, 8 months ago (2015-03-31 00:33:47 UTC) #3
garykac
On 2015/03/31 00:33:47, Dirk Pranke wrote: > Okay, I've pruned the webapp and a couple ...
5 years, 8 months ago (2015-03-31 17:39:00 UTC) #4
garykac
lgtm
5 years, 8 months ago (2015-03-31 17:39:06 UTC) #5
Dirk Pranke
On 2015/03/31 17:39:00, garykac wrote: > On 2015/03/31 00:33:47, Dirk Pranke wrote: > > Okay, ...
5 years, 8 months ago (2015-03-31 17:49:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039083004/40001
5 years, 8 months ago (2015-03-31 17:49:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/2835)
5 years, 8 months ago (2015-03-31 17:55:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039083004/80001
5 years, 8 months ago (2015-04-01 15:20:41 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_dbg on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/269)
5 years, 8 months ago (2015-04-01 15:27:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039083004/100001
5 years, 8 months ago (2015-04-01 17:22:49 UTC) #18
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-01 20:21:15 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 20:22:06 UTC) #20
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ce5eb83716e16f5b92e766ea95c70d2ed1b9ec17
Cr-Commit-Position: refs/heads/master@{#323314}

Powered by Google App Engine
This is Rietveld 408576698