Issue 1039083002: Revert of Enable gpu_times for all platforms other than windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1039083002: Revert of Enable gpu_times for all platforms other than windows. (Closed)

Created:
5 years, 9 months ago by Rick Byers

Modified:
5 years, 9 months ago

Reviewers:
nednguyen, David Yen

CC:
chromium-reviews, telemetry-reviews_chromium.org, vmiura, perf-sheriffs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Enable gpu_times for all platforms other than windows. (patchset #1 id:1 of https://codereview.chromium.org/1029423002/) Reason for revert: I'm seeing most perf bots failing gpu_times ever since this landed (Eg. http://goo.gl/uLzMVe). I missed this earlier because we had a bunch of persistent redness today caused by multiple bad V8 rolls and didn't notice this crept in as well. Failure is just on cuteoverload.com with this error: MarkerMismatchError: Number or order of timeline markers does not match provided labels Original issue's description: > Enable gpu_times for all platforms other than windows. > > R=nednguyen@google.com > BUG=453131, 455292 > > Committed: https://crrev.com/95325bb92cdce4b3c4fd93ae3509e72f89536c9c > Cr-Commit-Position: refs/heads/master@{#322273} TBR=nednguyen@google.com,dyen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453131, 455292 Committed: https://crrev.com/fb35ddbcc65dfcb4841298f233076be87e06236e Cr-Commit-Position: refs/heads/master@{#322514}

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	tools/perf/benchmarks/gpu_times.py	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

Rick Byers

Created Revert of Enable gpu_times for all platforms other than windows.

5 years, 9 months ago (2015-03-27 01:23:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039083002/1

5 years, 9 months ago (2015-03-27 01:24:11 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-27 01:25:47 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fb35ddbcc65dfcb4841298f233076be87e06236e
Cr-Commit-Position: refs/heads/master@{#322514}