Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1039043003: Fix TODO in chrome_web_view, use utils.lookup to find context menu events. (Closed)

Created:
5 years, 9 months ago by lazyboy
Modified:
5 years, 9 months ago
Reviewers:
paulmeyer
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TODO in chrome_web_view, use utils.lookup to find context menu events. This was done previously accessing array by index, which is brittle b/c this depends on the ordering of the events in web_view_internal.json. BUG=None Test=None, internal only cleanup. Committed: https://crrev.com/9a3fb195ffb589e011803aa17610aeff4a696683 Cr-Commit-Position: refs/heads/master@{#322588}

Patch Set 1 #

Patch Set 2 : forgot to remove the second todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/renderer/resources/extensions/web_view/chrome_web_view.js View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lazyboy
5 years, 9 months ago (2015-03-26 23:33:37 UTC) #2
paulmeyer
lgtm
5 years, 9 months ago (2015-03-27 13:04:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1039043003/20001
5 years, 9 months ago (2015-03-27 16:10:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 16:11:41 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 16:13:11 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a3fb195ffb589e011803aa17610aeff4a696683
Cr-Commit-Position: refs/heads/master@{#322588}

Powered by Google App Engine
This is Rietveld 408576698