Add base::TerminateBecauseOutOfMemory

base/process/memory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/logging.h"
 #include "base/process/memory.h"
 
 namespace base {
 
+namespace {
+
+// Breakpad server already classifies base::`anonymous namespace'::OnNoMemory as
+// out-of-memory crash.
+NOINLINE void OnNoMemory() {

[reveman, 2015/03/27 05:05:20]

We seem to have different implementations of this for each platform. Should
CrashWithOutOfMemory() be implemented in each platform specific file and use the
existing OnNoMemory() functions instead?

[Vitaly Buka (NO REVIEWS), 2015/03/27 06:29:13]

I guess it's just historical, I see no good reason to have this as platform
specific function. Later we replace platform specific with this one.

I don't want to do this right now to avoid changing crash stacks for stuff that
already classified, just in case. If this one classified as expected we can
consider removing platform specific code.

[reveman, 2015/03/27 13:04:50]

Looks like the return type of OnNoMemory is different depending on the platform.
However, if there's a clean way to avoid platform specific versions of this
function than that sgtm.

+  LOG(FATAL) << "Out of memory.";
+}
+
+}  // namespace
+
+void CrashWithOutOfMemory() {
+  OnNoMemory();
+}
+
 // Defined in memory_mac.mm for Mac.
 #if !defined(OS_MACOSX)
 
 bool UncheckedCalloc(size_t num_items, size_t size, void** result) {
   const size_t alloc_size = num_items * size;
 
   // Overflow check
   if (size && ((alloc_size / size) != num_items)) {
     *result = NULL;
     return false;
   }
 
   if (!UncheckedMalloc(alloc_size, result))
     return false;
 
   memset(*result, 0, alloc_size);
   return true;
 }
 
 #endif
 
 }  // namespace base