Source/modules/accessibility/AXNodeObject.cpp - Issue 1039023002: AX nodes that aren't contenteditable should be readonly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 1039023002: AX nodes that aren't contenteditable should be readonly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@listboxes_too

Patch Set: Add test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXNodeObject.cpp

diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp

index 75cd4a77849ba1a7e80ddbcd4286a37584464f44..3e50b23f67b661d41224b769a04c51a138bfe8a2 100644

--- a/Source/modules/accessibility/AXNodeObject.cpp

+++ b/Source/modules/accessibility/AXNodeObject.cpp

@@ -797,7 +797,7 @@ bool AXNodeObject::isReadOnly() const

return input.isReadOnly();

}

- return !node->hasEditableStyle();

+ return AXObject::isReadOnly();

}

bool AXNodeObject::isRequired() const

« no previous file with comments | « LayoutTests/accessibility/readonly-expected.txt ('k') | Source/modules/accessibility/AXObject.h » ('j') | no next file with comments »