Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1038993002: Docserver: Fix API refresh task names (Closed)

Created:
5 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Docserver: Fix API refresh task names So these tasks have been queueing with different path names than those used by the template processor. The latter uses "Unix name" equivalents of the API features, while the former was not. For example, "apps/appviewTag" has been caching as such but the template looks for "apps/appview_tag". It's unclear when this incongruity appeared but it explains several "my-docs-arent-updating" bugs that have appeared in the past several weeks. This changes the refresh servlet to queue API refresh tasks using API features in unix_name form, resolving the incongruity. BUG=471019 TBR=kalman@chromium.org Committed: https://crrev.com/7c5cf152973d5f5383d4a8a6ce9fc6ebb628811b Cr-Commit-Position: refs/heads/master@{#322496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/common/extensions/docs/server2/api_data_source.py View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/queue.yaml View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ken Rockot(use gerrit already)
Going to push this out since it works and it's live anyway.
5 years, 9 months ago (2015-03-26 22:47:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038993002/1
5 years, 9 months ago (2015-03-26 22:48:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 23:31:50 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 23:33:06 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c5cf152973d5f5383d4a8a6ce9fc6ebb628811b
Cr-Commit-Position: refs/heads/master@{#322496}

Powered by Google App Engine
This is Rietveld 408576698