Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 1038953002: [turbofan] Reduce JSLoadProperty and JSStoreProperty of strings to JSLoadNamed and JSStoreNamed. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reduce JSLoadProperty and JSStoreProperty of strings to JSLoadNamed and JSStoreNamed. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/29450e14cf79e515b58ea91af02fbf4fe4347026 Cr-Commit-Position: refs/heads/master@{#27669}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M src/compiler/js-type-feedback.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-type-feedback.cc View 4 chunks +30 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
5 years, 9 months ago (2015-03-26 17:55:32 UTC) #1
Michael Starzinger
LGTM. Sorry for the delay.
5 years, 8 months ago (2015-04-02 11:02:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038953002/20001
5 years, 8 months ago (2015-04-08 13:05:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 13:28:05 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 13:28:17 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29450e14cf79e515b58ea91af02fbf4fe4347026
Cr-Commit-Position: refs/heads/master@{#27669}

Powered by Google App Engine
This is Rietveld 408576698