Include external touchscreen vid/pid in UMA hardware profile

chrome/common/metrics/proto/system_profile.proto

Index: chrome/common/metrics/proto/system_profile.proto
diff --git a/chrome/common/metrics/proto/system_profile.proto b/chrome/common/metrics/proto/system_profile.proto
index abeea2bb0f269a0cffb5d528b80a890ce25bf025..8bd394fd4f61673dd97e4d75f81ec25ee2e67cba 100644
--- a/chrome/common/metrics/proto/system_profile.proto
+++ b/chrome/common/metrics/proto/system_profile.proto
@@ -83,7 +83,7 @@ message SystemProfileProto {
   }
   optional OS os = 5;
 
-  // Next tag for Hardware: 14
+  // Next tag for Hardware: 16
   // Information on the user's hardware.
   message Hardware {
     // The CPU architecture (x86, PowerPC, x86_64, ...)
@@ -219,6 +219,15 @@ message SystemProfileProto {
       repeated PairedDevice paired_device = 3;
     }
     optional Bluetooth bluetooth = 11;
+
+    optional bool is_touchscreen_present = 14;

[Ilya Sherman, 2013/12/12 22:49:43]

Please add documentation for all fields.  For very clearly named fields like
this one, brief documentation suffices.

[Ilya Sherman, 2013/12/12 22:49:43]

Why is this needed given external_touchscreen below?  Can't you just check the
length of the repeated field?

[tdresser, 2013/12/13 15:29:00]

is_touchscreen_present includes internal touchscreens, which don't have usb
vendor or product ids.

I've made this clearer and reduced the redundancy by replacing
|is_touchscreen_present| with |internal_display_supports_touch|.

I've added documentation for this field.

+
+    // vids and pids of external touchscreens.

[Ilya Sherman, 2013/12/12 22:49:43]

nit: Please spell out these acronyms.

[tdresser, 2013/12/13 15:29:00]

Done.

+    message TouchScreen {
+      optional uint32 vendor_id = 1;
+      optional uint32 product_id = 2;
+    }
+    repeated TouchScreen external_touchscreen = 15;
   }
   optional Hardware hardware = 6;