Include external touchscreen vid/pid in UMA hardware profile

chrome/browser/metrics/metrics_log.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/metrics_log.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 48 matching lines @@
 
 #if defined(OS_WIN)
 #include "base/win/metro.h"
 
 // http://blogs.msdn.com/oldnewthing/archive/2004/10/25/247180.aspx
 extern "C" IMAGE_DOS_HEADER __ImageBase;
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/user_manager.h"
+#include "ui/events/x/touch_factory_x11.h"
 #endif
 
 using content::GpuDataManager;
 using metrics::OmniboxEventProto;
 using metrics::PerfDataProto;
 using metrics::ProfilerEventProto;
 using metrics::SystemProfileProto;
 using tracked_objects::ProcessDataSnapshot;
 typedef chrome_variations::ActiveGroupId ActiveGroupId;
 typedef SystemProfileProto::GoogleUpdate::ProductInfo ProductInfo;
@@ skipping 294 matching lines @@
       return PairedDevice::DEVICE_MOUSE;
     case device::BluetoothDevice::DEVICE_TABLET:
       return PairedDevice::DEVICE_TABLET;
     case device::BluetoothDevice::DEVICE_KEYBOARD_MOUSE_COMBO:
       return PairedDevice::DEVICE_KEYBOARD_MOUSE_COMBO;
   }
 
   NOTREACHED();
   return PairedDevice::DEVICE_UNKNOWN;
 }
+
+void WriteTouchscreensProto(SystemProfileProto::Hardware* hardware) {
+  ui::TouchFactory* touch_factory = ui::TouchFactory::GetInstance();
+
+  hardware->set_is_touchscreen_present(touch_factory->IsTouchDevicePresent());
+
+  std::set<std::pair<int, int> > touchscreen_ids =
+      touch_factory->GetTouchscreenIds();
+  std::set<std::pair<int, int> >::iterator it;

[Ilya Sherman, 2013/12/12 22:49:43]

nit: Please declare this within the scope of the for loop rather than outside of
it.  (Also, I'm really looking forward to the days of C++11 and range-based for
loops...)

[tdresser, 2013/12/13 15:29:00]

Done.

+  for (it = touchscreen_ids.begin(); it != touchscreen_ids.end(); ++it) {
+    SystemProfileProto::Hardware::TouchScreen* touchscreen =
+        hardware->add_external_touchscreen();
+    touchscreen->set_vendor_id(it->first);
+    touchscreen->set_product_id(it->second);
+  }
+}
 #endif  // defined(OS_CHROMEOS)
 
 // Round a timestamp measured in seconds since epoch to one with a granularity
 // of an hour. This can be used before uploaded potentially sensitive
 // timestamps.
 int64 RoundSecondsToHour(int64 time_in_seconds) {
   return 3600 * (time_in_seconds / 3600);
 }
 
 }  // namespace
@@ skipping 406 matching lines @@
   if (perf_provider_.GetPerfData(&perf_data_proto))
     uma_proto()->add_perf_data()->Swap(&perf_data_proto);
 
   // BluetoothAdapterFactory::GetAdapter is synchronous on Chrome OS; if that
   // changes this will fail at the DCHECK().
   device::BluetoothAdapterFactory::GetAdapter(
       base::Bind(&MetricsLog::SetBluetoothAdapter,
                  base::Unretained(this)));
   DCHECK(adapter_.get());
   WriteBluetoothProto(hardware);
+  WriteTouchscreensProto(hardware);
   UpdateMultiProfileUserCount();
 #endif
 
   std::string serialied_system_profile;
   std::string base64_system_profile;
   if (system_profile->SerializeToString(&serialied_system_profile)) {
     base::Base64Encode(serialied_system_profile, &base64_system_profile);
     PrefService* local_state = GetPrefService();
     local_state->SetString(prefs::kStabilitySavedSystemProfile,
                            base64_system_profile);
@@ skipping 184 matching lines @@
 
     // We invalidate the user count if it changed while the log was open.
     if (system_profile->has_multi_profile_user_count() &&
         user_count != system_profile->multi_profile_user_count())
       user_count = 0;
 
     system_profile->set_multi_profile_user_count(user_count);
   }
 }
 #endif