src/api.cc - Issue 103893003: Do not stop profiling if all finished profiles were deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 103893003: Do not stop profiling if all finished profiles were deleted (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Comments addressed Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 290fcba97aa188a1fe1affb11ca1a4d3e86f62a7..45480baaf01e769567d4113b99284013f26cda59 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -7206,10 +7206,6 @@ void CpuProfile::Delete() {

i::CpuProfiler* profiler = isolate->cpu_profiler();

ASSERT(profiler != NULL);

profiler->DeleteProfile(reinterpret_cast<i::CpuProfile*>(this));

- if (profiler->GetProfilesCount() == 0) {

- // If this was the last profile, clean up all accessory data as well.

- profiler->DeleteAllProfiles();

- }

}

« no previous file with comments | « include/v8-profiler.h ('k') | src/cpu-profiler.cc » ('j') | no next file with comments »