Do not stop profiling if all finished profiles were deleted

Do not stop profiling if all finished profiles were deleted

Deleting finished profiles shouldn't interrupt profile recording.

BUG=chromium:327298
LOG=N
R=alph@chromium.org, jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18302

[alph, 2013-12-11 14:21:35]

lgtm

https://codereview.chromium.org/103893003/diff/1/test/cctest/test-cpu-profile...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/103893003/diff/1/test/cctest/test-cpu-profile...
test/cctest/test-cpu-profiler.cc:1552: v8::Handle<v8::String> innter =
v8::String::NewFromUtf8(isolate, "inner");
typo

[Jakob Kummerow, 2013-12-11 14:22:57]

Superficially LGTM with nits.

I leave the in-depth review to Ilya/Alexei.

https://codereview.chromium.org/103893003/diff/1/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):

https://codereview.chromium.org/103893003/diff/1/src/cpu-profiler.cc#newcode180
src/cpu-profiler.cc:180: // If this was the last profile, clean up all accessory
data as well.
nit: indentation

https://codereview.chromium.org/103893003/diff/1/test/cctest/test-cpu-profile...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/103893003/diff/1/test/cctest/test-cpu-profile...
test/cctest/test-cpu-profiler.cc:1552: v8::Handle<v8::String> innter =
v8::String::NewFromUtf8(isolate, "inner");
nit: I think you mean s/innter/inner/

[yurys, 2013-12-11 14:34:34]

Thanks for quick review!

https://codereview.chromium.org/103893003/diff/1/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):

https://codereview.chromium.org/103893003/diff/1/src/cpu-profiler.cc#newcode180
src/cpu-profiler.cc:180: // If this was the last profile, clean up all accessory
data as well.
On 2013/12/11 14:22:58, Jakob wrote:
> nit: indentation

Done.

https://codereview.chromium.org/103893003/diff/1/test/cctest/test-cpu-profile...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/103893003/diff/1/test/cctest/test-cpu-profile...
test/cctest/test-cpu-profiler.cc:1552: v8::Handle<v8::String> innter =
v8::String::NewFromUtf8(isolate, "inner");
On 2013/12/11 14:22:58, Jakob wrote:
> nit: I think you mean s/innter/inner/

Done.

https://codereview.chromium.org/103893003/diff/1/test/cctest/test-cpu-profile...
test/cctest/test-cpu-profiler.cc:1552: v8::Handle<v8::String> innter =
v8::String::NewFromUtf8(isolate, "inner");
On 2013/12/11 14:21:36, alph wrote:
> typo

Done.

[yurys, 2013-12-11 14:39:29]

Committed patchset #2 manually as r18302.