Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1038913004: Add missing task_queue.cc to sync_core GN sources list. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
brettw, Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org, brettw, Dirk Pranke, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing task_queue.cc to sync_core GN sources list. This was found by looking at the output of gyp_flag_compare step in http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/25653/steps/gyp_flag_compare/logs/stdio BUG=None TEST=gn gen out-gn R=brettw@chromium.org TBR=zea@chromium.org Committed: https://crrev.com/870780454b5e8fe4687313504b6c4d324a627df7 Cr-Commit-Position: refs/heads/master@{#322662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sync/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
PTAL
5 years, 8 months ago (2015-03-26 17:20:38 UTC) #1
brettw
lgtm
5 years, 8 months ago (2015-03-26 17:32:45 UTC) #3
tfarina
TBRing Nicolas for this, it is trivial!
5 years, 8 months ago (2015-03-27 22:16:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038913004/1
5 years, 8 months ago (2015-03-27 22:17:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-27 22:40:23 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-03-27 22:41:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/870780454b5e8fe4687313504b6c4d324a627df7
Cr-Commit-Position: refs/heads/master@{#322662}

Powered by Google App Engine
This is Rietveld 408576698