Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1038903003: Fix crash occurring during infobar dismissal at BVC deletion. (Closed)

Created:
5 years, 9 months ago by jif
Modified:
5 years, 9 months ago
Reviewers:
droger, jif-google
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash occurring during infobar dismissal at BVC deletion. Calling the InfoBarContainerIOS destructor leads to the removal of infobars via |InfoBarContainerIOS::PlatformSpecificRemoveInfoBar|, which leads to the BVC wanting to change the InfoBarContainerIOS's height (in |infoBarContainerStateChanged|) This leads to a crash because the InfoBarContainerIOS is in the process of being deleted. This CL makes the flow abort early. BUG=448093 Committed: https://crrev.com/695932863ee381ddcb55a61eae9e5f0623df9138 Cr-Commit-Position: refs/heads/master@{#322432}

Patch Set 1 #

Patch Set 2 : v2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/chrome/browser/infobars/infobar_container_ios.mm View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jif
ptal
5 years, 9 months ago (2015-03-26 17:49:22 UTC) #3
droger
lgtm
5 years, 9 months ago (2015-03-26 17:57:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038903003/40001
5 years, 9 months ago (2015-03-26 17:58:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-26 18:27:48 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 18:28:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/695932863ee381ddcb55a61eae9e5f0623df9138
Cr-Commit-Position: refs/heads/master@{#322432}

Powered by Google App Engine
This is Rietveld 408576698