Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: gyp/images.gyp

Issue 1038863003: WIP: Added support for giflib, updated jpeg and png (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Added dependencies! and flags Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gyp/images.gyp
diff --git a/gyp/images.gyp b/gyp/images.gyp
index 4cce08e7a1e5b26810ee9aa6ec6847356559efb5..34cc8a8fa89825077e78acbe4e4112d34c5b565e 100644
--- a/gyp/images.gyp
+++ b/gyp/images.gyp
@@ -2,6 +2,7 @@
#
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+
# GYP file for images project.
{
'targets': [
@@ -12,6 +13,7 @@
'standalone_static_library': 1,
'dependencies': [
'core.gyp:*',
+ 'giflib.gyp:giflib',
'libjpeg.gyp:*',
'etc1.gyp:libetc1',
'ktx.gyp:libSkKTX',
@@ -87,6 +89,9 @@
'../src/images/SkImageDecoder_libpng.cpp',
'../src/images/SkMovie_gif.cpp',
],
+ 'dependencies!': [
+ 'giflib.gyp:giflib'
+ ],
'link_settings': {
'libraries': [
'-lwindowscodecs.lib',
@@ -112,13 +117,11 @@
[ 'skia_os in ["linux", "freebsd", "openbsd", "solaris"]', {
'export_dependent_settings': [
'libpng.gyp:libpng',
- 'giflib.gyp:giflib'
],
'dependencies': [
'libpng.gyp:libpng',
- 'giflib.gyp:giflib'
],
- # end libpng/libgif stuff
+ # end libpng stuff
}],
# FIXME: NaCl should be just like linux, etc, above, but it currently is separated out
msarett 2015/03/27 14:47:29 Just noticed this comment. If this is still the c
scroggo 2015/03/27 14:55:46 I think we don't support nacl anymore? Pretty sure
# to remove gif. Once gif is supported by naclports, this can be merged into the above
@@ -128,13 +131,15 @@
'../src/images/SkImageDecoder_libgif.cpp',
'../src/images/SkMovie_gif.cpp',
],
+ 'dependencies!': [
+ 'giflib.gyp:giflib'
+ ],
}],
[ 'skia_os == "android"', {
'include_dirs': [
'../src/utils',
],
'dependencies': [
- 'android_deps.gyp:gif',
'android_deps.gyp:png',
],
'conditions': [
@@ -156,8 +161,7 @@
}],
[ 'skia_os == "chromeos"', {
'dependencies': [
- 'chromeos_deps.gyp:gif',
- 'libpng.gyp:libpng',
+ 'libpng.gyp:libpng',
],
}],
[ 'skia_os == "ios"', {

Powered by Google App Engine
This is Rietveld 408576698