Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: gyp/giflib.gyp

Issue 1038863003: WIP: Added support for giflib, updated jpeg and png (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 Google Inc. 1 # Copyright 2014 Google Inc.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 { 6 {
7 'variables': { 7 'variables': {
8 'skia_warnings_as_errors': 0, 8 'skia_warnings_as_errors': 0,
9 }, 9 },
10 'targets': [ 10 'targets': [
11 { 11 {
12 'target_name': 'giflib', 12 'target_name': 'giflib',
13 'conditions': [ 13 'conditions': [
14 [ 'skia_giflib_static', 14 [ 'skia_os != "android"',
msarett 2015/03/26 18:22:46 As far as I can tell, this is always 0. So past c
scroggo 2015/03/26 18:29:34 Dead code. We should probably remove skia_giflib_s
msarett 2015/03/26 21:06:23 Done.
15 { 15 {
16 'type': 'static_library', 16 'type': 'static_library',
17 'defines': [ 17 'defines': [
18 'HAVE_CONFIG_H', 18 'HAVE_CONFIG_H',
19 ], 19 ],
20 'include_dirs': [ 20 'include_dirs': [
21 '../third_party/externals/giflib', 21 '../third_party/externals/giflib',
22 ], 22 ],
23 'dependencies': [ 23 'dependencies': [
24 ], 24 ],
25 'direct_dependent_settings': { 25 'direct_dependent_settings': {
26 'include_dirs': [ 26 'include_dirs': [
27 '../third_party/externals/giflib', 27 '../third_party/externals/giflib',
28 ], 28 ],
29 }, 29 },
30 'cflags': [ 30 'cflags': [
31 '-w', 31 '-w',
32 ], 32 ],
33 'sources': [ 33 'sources': [
34 '../third_party/externals/giflib/dgif_lib.c', 34 '../third_party/externals/giflib/dgif_lib.c',
35 '../third_party/externals/giflib/gifalloc.c', 35 '../third_party/externals/giflib/gifalloc.c',
36 '../third_party/externals/giflib/gif_err.c', 36 '../third_party/externals/giflib/gif_err.c',
37 ], 37 ],
38 }, { # not skia_giflib_static 38 }, { # skia_os == "android"
djsollen 2015/03/26 19:51:05 let's not make the distinction between android and
scroggo 2015/03/26 20:10:11 We *do* need to make a distinction for skia_androi
msarett 2015/03/26 21:06:23 Gotcha.
39 'type': 'none', 39 'type': 'static_library',
40 'direct_dependent_settings': { 40 'dependencies': [
41 'link_settings': { 41 'android_deps.gyp:gif',
msarett 2015/03/26 18:22:46 For android, do what images.gyp does and use andro
42 'libraries': [ 42 ],
43 '-lgif',
44 ],
45 },
46 },
47 } 43 }
48 ], 44 ],
49 ] 45 ]
50 } 46 }
51 ] 47 ]
52 } 48 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698