Issue 1038813005: Move terminal example from //sky/examples to //examples

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1038813005: Move terminal example from //sky/examples to //examples (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
vtl, viettrungluu

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Move terminal example from //sky/examples to //examples We're trying to clean up the //sky/examples directory to focus on mobile use cases for the fn framework. Terminal is both focused on desktop and uses the older custom-element framework. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c521afac355797f68ecc8503c78614c68c369a95

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-5 lines, -388 lines)			Patch
A +	examples/terminal/README.md	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	examples/terminal/index.sky	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	examples/terminal/terminal.sky	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	examples/terminal/terminal_display.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	examples/terminal/terminal_file_impl.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	sky/examples/terminal/README.md	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	sky/examples/terminal/index.sky	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	sky/examples/terminal/terminal.sky	View	1 chunk	+0 lines, -218 lines	0 comments	Download
D	sky/examples/terminal/terminal_display.dart	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	sky/examples/terminal/terminal_file_impl.dart	View	1 chunk	+0 lines, -124 lines	0 comments	Download

Total messages: 5 (2 generated)

abarth-chromium

5 years, 9 months ago (2015-03-26 21:53:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c521afac355797f68ecc8503c78614c68c369a95 (presubmit successful).